Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errors parameter for CsvItemExporter with tests #4755

merged 3 commits into from Aug 27, 2020


Copy link

@maranqz maranqz commented Aug 25, 2020

Additional context from #4754

Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #4755 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4755   +/-   ##
  Coverage   87.17%   87.18%           
  Files         160      160           
  Lines        9815     9814    -1     
  Branches     1447     1448    +1     
  Hits         8556     8556           
  Misses        996      996           
+ Partials      263      262    -1     
Impacted Files Coverage Δ
scrapy/ 100.00% <100.00%> (ø)
scrapy/core/downloader/handlers/ 93.03% <0.00%> (ø)
scrapy/utils/ 96.09% <0.00%> (+0.12%) ⬆️
scrapy/utils/ 94.59% <0.00%> (+1.73%) ⬆️

Copy link

@Gallaecio Gallaecio left a comment

Looks good to me, only the documentation update is missing:

docs/topics/exporters.rst Outdated Show resolved Hide resolved
Copy link

kmike commented Aug 26, 2020

Hey! Just to make sure - is my understanding is correct?

  • As implemented, this is a feature which is not easily accessable for the end users, unless they use exporters directly in their code
  • to make it available through FEEDS option Pass info from FEEDS to ItemExporter #4606 needs to be fixed, which was out of scope for this PR

Copy link
Contributor Author

maranqz commented Aug 27, 2020

@kmike Yes, you are right. I think to do that task #4606 during the month.

@kmike kmike merged commit a6b67cf into scrapy:master Aug 27, 2020
2 checks passed
Copy link

kmike commented Aug 27, 2020

Thanks @maranqz!

@maranqz maranqz deleted the csv-item-exporter-errors branch Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants