Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate localhost keys for tests on the fly #4761

Merged
merged 1 commit into from Sep 2, 2020

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Aug 27, 2020

Fixes #4651

@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #4761 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4761      +/-   ##
==========================================
+ Coverage   87.16%   87.18%   +0.02%     
==========================================
  Files         160      160              
  Lines        9814     9814              
  Branches     1448     1448              
==========================================
+ Hits         8554     8556       +2     
+ Misses        997      996       -1     
+ Partials      263      262       -1     
Impacted Files Coverage Δ
scrapy/core/downloader/__init__.py 90.97% <0.00%> (+1.50%) ⬆️

wRAR
wRAR approved these changes Sep 2, 2020
@wRAR wRAR merged commit c1cc3f2 into scrapy:master Sep 2, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have tests generate a certificate on-the-fly
2 participants