Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify tests/test_crawl #4765

Merged
merged 1 commit into from Aug 29, 2020
Merged

Simplify tests/test_crawl #4765

merged 1 commit into from Aug 29, 2020

Conversation

wRAR
Copy link
Contributor

@wRAR wRAR commented Aug 28, 2020

This adds a single function to run a spider and collect the items, logs and stats, to simplify existing and future test cases.

Includes #4764

@wRAR wRAR changed the title Simplify test crawl Simplify tests/test_crawl Aug 28, 2020
@wRAR wRAR added this to the 2.4 milestone Aug 28, 2020
@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #4765 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4765   +/-   ##
=======================================
  Coverage   87.19%   87.19%           
=======================================
  Files         160      160           
  Lines        9812     9812           
  Branches     1447     1447           
=======================================
  Hits         8556     8556           
  Misses        995      995           
  Partials      261      261           

@wRAR wRAR closed this Aug 28, 2020
@wRAR wRAR reopened this Aug 28, 2020
@kmike
Copy link
Member

kmike commented Aug 28, 2020

The diff is confusiing :) I'd expect only last changes to be present. Could you please check it @wRAR?

@wRAR
Copy link
Contributor Author

wRAR commented Aug 29, 2020

Yeah, I have no idea why does it still show the merged commit.

@wRAR wRAR force-pushed the simplify-test_crawl branch from eaf8449 to 8123c42 Compare Aug 29, 2020
@kmike
Copy link
Member

kmike commented Aug 29, 2020

Nice cleanup, thanks @wRAR!

@kmike kmike merged commit be655b8 into master Aug 29, 2020
2 checks passed
@wRAR wRAR deleted the simplify-test_crawl branch Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants