Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for unparseable no_proxy values #4778

Merged
merged 2 commits into from Oct 1, 2020

Conversation

drs-11
Copy link
Contributor

@drs-11 drs-11 commented Sep 5, 2020

Fixes #3331

/var/run/docker.sock seemed an exceptional case when a socket file is used in no_proxy env variable which is unparseable by the urllib.request._parse_proxy method.

@codecov
Copy link

codecov bot commented Sep 5, 2020

Codecov Report

Merging #4778 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4778   +/-   ##
=======================================
  Coverage   87.21%   87.21%           
=======================================
  Files         160      160           
  Lines        9813     9816    +3     
  Branches     1447     1447           
=======================================
+ Hits         8558     8561    +3     
  Misses        994      994           
  Partials      261      261           
Impacted Files Coverage Δ
scrapy/downloadermiddlewares/httpproxy.py 100.00% <100.00%> (ø)

@kmike kmike merged commit f173af6 into scrapy:master Oct 1, 2020
1 check passed
@kmike
Copy link
Member

kmike commented Oct 1, 2020

Thanks @drs-11!

@drs-11 drs-11 deleted the unparseable-no-proxy-fix branch Oct 2, 2020
@drs-11 drs-11 restored the unparseable-no-proxy-fix branch Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation example fails with proxy URL with no authority
3 participants