Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mention of FTP server storage in media storage intro #4782

Merged
merged 1 commit into from Sep 14, 2020

Conversation

sripriyesha
Copy link
Contributor

@sripriyesha sripriyesha commented Sep 8, 2020

At the beginning of this doc, in "Specifying where to store the media" feature details, FTP server storage mention was missing

At the beginning of this doc, in "Specifying where to store the media" feature details, FTP server storage mention was missing
@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #4782 into master will increase coverage by 0.86%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4782      +/-   ##
==========================================
+ Coverage   86.32%   87.19%   +0.86%     
==========================================
  Files         160      160              
  Lines        9669     9813     +144     
  Branches     1419     1447      +28     
==========================================
+ Hits         8347     8556     +209     
+ Misses       1062      995      -67     
- Partials      260      262       +2     
Impacted Files Coverage Δ
scrapy/core/downloader/webclient.py 94.48% <0.00%> (-3.48%) ⬇️
scrapy/utils/trackref.py 82.85% <0.00%> (-2.86%) ⬇️
scrapy/core/scraper.py 87.11% <0.00%> (-0.86%) ⬇️
scrapy/cmdline.py 67.20% <0.00%> (-0.55%) ⬇️
scrapy/utils/defer.py 95.45% <0.00%> (-0.20%) ⬇️
scrapy/pipelines/media.py 97.16% <0.00%> (-0.14%) ⬇️
scrapy/pqueues.py 99.08% <0.00%> (ø)
scrapy/utils/gz.py 96.87% <0.00%> (ø)
scrapy/exporters.py 100.00% <0.00%> (ø)
scrapy/spiderloader.py 100.00% <0.00%> (ø)
... and 32 more

Copy link
Member

@Gallaecio Gallaecio left a comment

Nice catch, thank you!

@kmike kmike merged commit 85e13af into scrapy:master Sep 14, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants