Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logging error with unicode spider name #479

Merged
merged 1 commit into from Dec 18, 2013

Conversation

@citizen-stig
Copy link
Contributor

@citizen-stig citizen-stig commented Nov 30, 2013

Log message fails if spider name is in unicode, because "system" key in eventDict isn't encoded.

Log message fails if spider name is in unicode, because "system" key in eventDict isn't encoded.
@kmike
Copy link
Member

@kmike kmike commented Dec 18, 2013

Thanks!

kmike added a commit that referenced this pull request Dec 18, 2013
fix logging error with unicode spider name
@kmike kmike merged commit 93eee9d into scrapy:master Dec 18, 2013
1 check passed
1 check passed
default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.