Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed datatype specification for *args & ** kwargs #4816

Merged
merged 1 commit into from Oct 1, 2020

Conversation

sashreek1
Copy link
Contributor

@sashreek1 sashreek1 commented Oct 1, 2020

I have opened this pull request in accordance to #4805
I have essentially removed the data type specification for *args and **kwargs as it had some unforeseen consequences.(refer to #4805 )

Fixes #4805

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #4816 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4816      +/-   ##
==========================================
+ Coverage   87.52%   87.54%   +0.02%     
==========================================
  Files         160      160              
  Lines        9761     9761              
  Branches     1440     1440              
==========================================
+ Hits         8543     8545       +2     
+ Misses        955      954       -1     
+ Partials      263      262       -1     
Impacted Files Coverage Δ
scrapy/crawler.py 88.26% <ø> (ø)
scrapy/core/downloader/__init__.py 92.48% <0.00%> (+1.50%) ⬆️

@kmike kmike merged commit 7b1bc9b into scrapy:master Oct 1, 2020
1 check passed
@kmike
Copy link
Member

kmike commented Oct 1, 2020

Thanks @sashreek1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong annotations in scrapy.crawler.CrawlProcess.crawl docstrings
3 participants