Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not consider about: URLs invalid #4835

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Do not consider about: URLs invalid #4835

merged 1 commit into from
Oct 7, 2020

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Oct 6, 2020 •
edited
Loading

@Gallaecio Gallaecio added the bug label Oct 6, 2020
@codecov
Copy link

codecov bot commented Oct 6, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@b1255b0). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #4835   +/-   ##
=========================================
  Coverage          ?   87.88%           
=========================================
  Files             ?      160           
  Lines             ?     9743           
  Branches          ?     1439           
=========================================
  Hits              ?     8563           
  Misses            ?      923           
  Partials          ?      257
Impacted Files Coverage Δ
scrapy/http/request/__init__.py 97.26% <100.00%> (ø)

@wRAR wRAR merged commit ded9a5a into scrapy:master Oct 7, 2020
@Gallaecio Gallaecio mentioned this pull request Oct 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wRAR wRAR wRAR approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gallaecio @wRAR