Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved the sentence about processing pending requests when a spider is closed onto a generic note. #4836

Merged
merged 1 commit into from Oct 7, 2020

Conversation

OfirD1
Copy link
Contributor

@OfirD1 OfirD1 commented Oct 6, 2020

No description provided.

Copy link
Member

@Gallaecio Gallaecio left a comment

Looks good to me, thanks!

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

No coverage uploaded for pull request base (master@b1255b0). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4836   +/-   ##
=========================================
  Coverage          ?   87.88%           
=========================================
  Files             ?      160           
  Lines             ?     9743           
  Branches          ?     1439           
=========================================
  Hits              ?     8563           
  Misses            ?      923           
  Partials          ?      257           

@OfirD1 OfirD1 closed this Oct 7, 2020
@OfirD1 OfirD1 reopened this Oct 7, 2020
@OfirD1
Copy link
Contributor Author

OfirD1 commented Oct 7, 2020

Thanks. I accidentally closed it, so I'm reopening it so that it could get merged.

wRAR
wRAR approved these changes Oct 7, 2020
@wRAR wRAR merged commit 8fc4e2e into scrapy:master Oct 7, 2020
2 checks passed
@OfirD1 OfirD1 deleted the patch-1 branch Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants