Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xfail_strict=true to pytest.ini #4839

Merged
merged 1 commit into from Oct 8, 2020

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Oct 8, 2020

Following up #4823 (comment)

@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #4839 into master will decrease coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4839      +/-   ##
==========================================
- Coverage   87.85%   87.65%   -0.21%     
==========================================
  Files         160      160              
  Lines        9735     9735              
  Branches     1437     1437              
==========================================
- Hits         8553     8533      -20     
- Misses        925      944      +19     
- Partials      257      258       +1     
Impacted Files Coverage Δ
scrapy/robotstxt.py 75.30% <0.00%> (-22.23%) ⬇️
scrapy/core/downloader/__init__.py 90.97% <0.00%> (-1.51%) ⬇️

wRAR
wRAR approved these changes Oct 8, 2020
@wRAR wRAR merged commit da426fb into scrapy:master Oct 8, 2020
2 checks passed
@elacuesta elacuesta deleted the pytest_xfail_strict branch Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants