Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SgmlLinkExtractor: Fixed link text when there is an inner tag #485

Merged
merged 3 commits into from Feb 1, 2014

Conversation

@bblanchon
Copy link
Contributor

@bblanchon bblanchon commented Dec 7, 2013

This PR fixes the use case where the link is written like this:

<a href="helloworld.htm"><b>Hello</b> world</a>

With the previous implementation, it returned a Link.text set to "Hello".
Now, it returns "Hello world", as expected.

@dangra
Copy link
Member

@dangra dangra commented Dec 16, 2013

LGTM

/cc @pablohoffman

pablohoffman added a commit that referenced this pull request Feb 1, 2014
SgmlLinkExtractor: Fixed link text when there is an inner tag
@pablohoffman pablohoffman merged commit c928eef into scrapy:master Feb 1, 2014
1 check passed
1 check passed
default The Travis CI build passed
Details
@pablohoffman
Copy link
Member

@pablohoffman pablohoffman commented Feb 1, 2014

sorry for the delayed merge on this one!

redapple added a commit to redapple/scrapy that referenced this pull request Feb 1, 2014
redapple added a commit to redapple/scrapy that referenced this pull request Feb 1, 2014
redapple added a commit to redapple/scrapy that referenced this pull request Feb 1, 2014
dangra added a commit that referenced this pull request Feb 3, 2014
Fix HtmlParserLinkExtractor and tests after #485 merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants