SgmlLinkExtractor: Fixed link text when there is an inner tag #485
Conversation
…rent_link=None when the end tag match the opening tag
|
LGTM /cc @pablohoffman |
pablohoffman
added a commit
that referenced
this pull request
Feb 1, 2014
SgmlLinkExtractor: Fixed link text when there is an inner tag
|
sorry for the delayed merge on this one! |
redapple
added a commit
to redapple/scrapy
that referenced
this pull request
Feb 1, 2014
redapple
added a commit
to redapple/scrapy
that referenced
this pull request
Feb 1, 2014
redapple
added a commit
to redapple/scrapy
that referenced
this pull request
Feb 1, 2014
dangra
added a commit
that referenced
this pull request
Feb 3, 2014
Fix HtmlParserLinkExtractor and tests after #485 merge
dangra
added a commit
that referenced
this pull request
Feb 5, 2014
dangra
added a commit
that referenced
this pull request
Feb 5, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR fixes the use case where the link is written like this:
With the previous implementation, it returned a
Link.textset to "Hello".Now, it returns "Hello world", as expected.