overwrite an output file with -O, (FeedExporter updated) #4859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4859 +/- ##
=======================================
Coverage 87.86% 87.86%
=======================================
Files 160 160
Lines 9749 9749
Branches 1439 1439
=======================================
Hits 8566 8566
Misses 926 926
Partials 257 257
|
kmike
reviewed
Oct 29, 2020
tests/test_commands.py
Outdated
| @@ -680,9 +680,14 @@ def start_requests(self): | |||
| ) | |||
| return [] | |||
| """ | |||
| with open(os.path.join(self.cwd, "example.json"), "w") as file: | |||
There was a problem hiding this comment.
file is a built-in in Python, should we change it to something like fp?
There was a problem hiding this comment.
Ok. I renamed it.
kmike
approved these changes
Oct 29, 2020
Gallaecio
approved these changes
Oct 30, 2020
|
Thank you! |
|
This didn't close the linked issues, is there anything else needed for them? |
|
I believe we simply forgot to set the pull request description to do it. Both are closed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
related to #4857 and #4845
FeedExporter._get_storage()updated -feed_optionssuccessfully passed to Storage objectsCrawlCommandTest.test_overwrite_outputandRunSpiderCommandTest.test_overwrite_outputaimed to test-Oarg - updated.