Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect output on the genspider command #4874

Merged
merged 1 commit into from Nov 10, 2020

Conversation

stummjr
Copy link
Member

@stummjr stummjr commented Nov 8, 2020

When running inside a project, the genspider command is outputting string placeholders rather than their actual contents.

Example:

$  scrapy genspider example example.com
Created spider 'example' using template 'basic' in module:
  {spiders_module.__name__}.{module}

This PR fixes it, by adding the missing f-string prefix to the string that represents that message.

@stummjr stummjr force-pushed the fix-missing-fstring-prefix-genspider branch from 3b848e0 to a2c4a7f Compare November 8, 2020 23:15
@codecov
Copy link

codecov bot commented Nov 8, 2020

Codecov Report

Merging #4874 (a2c4a7f) into master (c292957) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4874      +/-   ##
==========================================
+ Coverage   87.84%   87.86%   +0.02%     
==========================================
  Files         160      160              
  Lines        9749     9749              
  Branches     1439     1439              
==========================================
+ Hits         8564     8566       +2     
+ Misses        927      926       -1     
+ Partials      258      257       -1     
Impacted Files Coverage Δ
scrapy/commands/genspider.py 87.00% <100.00%> (ø)
scrapy/core/downloader/__init__.py 92.48% <0.00%> (+1.50%) ⬆️

Copy link
Member

@elacuesta elacuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Valdir! Nice to see you around 😉

@kmike kmike merged commit 91a8451 into scrapy:master Nov 10, 2020
2 checks passed
@kmike
Copy link
Member

kmike commented Nov 10, 2020

Thanks @stummjr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants