Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response.protocol attribute #4878

Merged
merged 9 commits into from Dec 16, 2020

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta commented Nov 11, 2020

Motivated by #4769 and #4770

$ scrapy shell https://example.org
(...)
>>> response.protocol
'HTTP/1.1'
>>> 

@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #4878 (2405df4) into master (c20b342) will decrease coverage by 0.02%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master    #4878      +/-   ##
==========================================
- Coverage   87.86%   87.84%   -0.03%     
==========================================
  Files         160      160              
  Lines        9750     9762      +12     
  Branches     1439     1437       -2     
==========================================
+ Hits         8567     8575       +8     
- Misses        926      929       +3     
- Partials      257      258       +1     
Impacted Files Coverage Δ
scrapy/core/downloader/handlers/http11.py 92.46% <60.00%> (-0.57%) ⬇️
scrapy/core/downloader/webclient.py 94.48% <100.00%> (ø)
scrapy/http/response/__init__.py 97.40% <100.00%> (+0.03%) ⬆️
scrapy/core/downloader/__init__.py 90.97% <0.00%> (-1.51%) ⬇️
scrapy/extensions/feedexport.py 95.32% <0.00%> (+0.10%) ⬆️

@kmike
Copy link
Member

kmike commented Nov 11, 2020

Nice feature 👍

Copy link
Member

@kmike kmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @elacuesta!
As @Gallaecio also checked it, I'll leave it to him to merge.

@Gallaecio Gallaecio merged commit d0af008 into scrapy:master Dec 16, 2020
@elacuesta elacuesta deleted the response-protocol-attribute branch December 31, 2020 14:38
@elacuesta elacuesta added this to the 2.5 milestone Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants