New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Response.protocol attribute #4878
Merged
Gallaecio
merged 9 commits into
scrapy:master
from
elacuesta:response-protocol-attribute
Dec 16, 2020
Merged
Response.protocol attribute #4878
Gallaecio
merged 9 commits into
scrapy:master
from
elacuesta:response-protocol-attribute
Dec 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4878 +/- ##
==========================================
- Coverage 87.86% 87.84% -0.03%
==========================================
Files 160 160
Lines 9750 9762 +12
Branches 1439 1437 -2
==========================================
+ Hits 8567 8575 +8
- Misses 926 929 +3
- Partials 257 258 +1
|
kmike
reviewed
Nov 11, 2020
kmike
reviewed
Nov 11, 2020
Nice feature 👍 |
kmike
approved these changes
Dec 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks @elacuesta!
As @Gallaecio also checked it, I'll leave it to him to merge.
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by #4769 and #4770