New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate scrapy.utils.py36 module #4900
Conversation
|
||
|
||
logger = logging.getLogger(__name__) | ||
|
||
|
||
def iterate_spider_output(result): | ||
if collect_asyncgen and hasattr(inspect, 'isasyncgen') and inspect.isasyncgen(result): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inspect.isasyncgen
was added in Python 3.6
This is actually done in #4467 (not sure why I didn't think of extracting this change), though the function is moved to |
Ohh 🤦 |
Well, I think it's good that this will be merged separately as it reduces the diff and works fine as a separate change. |
Codecov Report
@@ Coverage Diff @@
## master #4900 +/- ##
==========================================
+ Coverage 87.87% 87.89% +0.02%
==========================================
Files 160 161 +1
Lines 9756 9757 +1
Branches 1437 1437
==========================================
+ Hits 8573 8576 +3
+ Misses 926 924 -2
Partials 257 257
|
Now that the minimum Python version is 3.6, there is no need to keep this helper in a different file and catch the
SyntaxError
when importing.