Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added customized filtering examples in logging.rst #4965

Merged
merged 7 commits into from Apr 1, 2021

Conversation

anay2103
Copy link
Contributor

@anay2103 anay2103 commented Jan 28, 2021

Added a tutorial example how to filter root logger or any custom logger with a regular expression.

Resolves #4216, closes #4257

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #4965 (91d9734) into master (28262d4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4965   +/-   ##
=======================================
  Coverage   88.02%   88.02%           
=======================================
  Files         158      158           
  Lines        9719     9719           
  Branches     1433     1433           
=======================================
  Hits         8555     8555           
  Misses        910      910           
  Partials      254      254           

Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! And it works, which is most important 😃

docs/topics/logging.rst Outdated Show resolved Hide resolved
docs/topics/logging.rst Outdated Show resolved Hide resolved
docs/topics/logging.rst Outdated Show resolved Hide resolved
docs/topics/logging.rst Outdated Show resolved Hide resolved
anay2103 and others added 4 commits January 29, 2021 01:57
Co-authored-by: Adrián Chaves <adrian@chaves.io>
Co-authored-by: Adrián Chaves <adrian@chaves.io>
Co-authored-by: Adrián Chaves <adrian@chaves.io>
Co-authored-by: Adrián Chaves <adrian@chaves.io>
@anay2103
Copy link
Contributor Author

@Gallaecio Thanks for your accurate suggestions, i like them 😃

@anay2103 anay2103 closed this Jan 28, 2021
@anay2103 anay2103 reopened this Jan 28, 2021
Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anay2103 anay2103 closed this Jan 29, 2021
@Gallaecio Gallaecio reopened this Jan 29, 2021
@anay2103 anay2103 closed this Jan 29, 2021
@anay2103 anay2103 reopened this Jan 29, 2021
@Gallaecio
Copy link
Member

Gallaecio commented Jan 29, 2021

@anay2103 Do not worry about the test issues. Unless it’s the docs job, issues are not related to your changes.

@anay2103
Copy link
Contributor Author

@Gallaecio Got it!

@kmike
Copy link
Member

kmike commented Apr 1, 2021

Thanks @anay2103!

@kmike kmike merged commit 5492972 into scrapy:master Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cover arbitrary filtering in the Scrapy logging documentation
3 participants