Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move lists closer to their introducing paragraph #4974

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Feb 3, 2021

This has been bothering me for a while.

I’ve not reviewed the effect in the whole documentation, but I’ve had a look at pages from the main page to the settings page, which is about half the documentation, and it looks good to me.

Before:
Screenshot_2021-02-03 Scrapy 2 4 documentation — Scrapy 2 4 1 documentation(1)

After:
Screenshot_2021-02-03 Scrapy 2 4 documentation — Scrapy 2 4 1 documentation

Changes to reStructuredText files are so that lists which were put within a blockquote because of the empty space that precedes their * are now regular lists.

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #4974 (e2fba0c) into master (904a501) will increase coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4974      +/-   ##
==========================================
+ Coverage   87.81%   88.00%   +0.18%     
==========================================
  Files         158      158              
  Lines        9719     9719              
  Branches     1433     1433              
==========================================
+ Hits         8535     8553      +18     
+ Misses        929      911      -18     
  Partials      255      255              
Impacted Files Coverage Δ
scrapy/robotstxt.py 97.53% <0.00%> (+22.22%) ⬆️

Copy link
Member

@kmike kmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@kmike kmike merged commit b09ff99 into scrapy:master Apr 1, 2021
@kmike
Copy link
Member

kmike commented Apr 6, 2021

Hey @Gallaecio! The menu on the left doesn't look right on readthedocs:

image

Do you know if it can be caused by this change?

@Gallaecio
Copy link
Member Author

I assume it was caused by this change, but I did render the latest changes locally as I was working on the release notes, so I suspect the issue is not reproducible locally.

I’ll look into it when I get a chance.

@Gallaecio
Copy link
Member Author

I’ve rebuild 2.4.0 and the same happens in ReadTheDocs.

@Gallaecio
Copy link
Member Author

It turns out it was not these changes: readthedocs/readthedocs.org#8070

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants