/ scrapy Public
Refactor SpiderMiddlewareManager.scrape_response. #4982
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
I decided to extract nested functions from the method because after adding more code there in #4978 pylint was raising "Too many statements". Looks like they were nested to be able to access several vars from the outside scope so now they are passed explicitly. I don't know if this is the best way to resolve this, so suggestions are welcome.