Refactor SpiderMiddlewareManager.scrape_response. #4982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4982 +/- ##
==========================================
+ Coverage 87.81% 88.02% +0.21%
==========================================
Files 158 158
Lines 9719 9723 +4
Branches 1433 1433
==========================================
+ Hits 8535 8559 +24
+ Misses 929 910 -19
+ Partials 255 254 -1
|
Gallaecio
approved these changes
Feb 8, 2021
elacuesta
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I decided to extract nested functions from the method because after adding more code there in #4978 pylint was raising "Too many statements". Looks like they were nested to be able to access several vars from the outside scope so now they are passed explicitly. I don't know if this is the best way to resolve this, so suggestions are welcome.