Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close files in the PerYearXmlExportPipeline documentation example #5008

Merged
merged 1 commit into from Feb 24, 2021

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Feb 24, 2021

Fixes #4829, closes #4830

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #5008 (febd6d1) into master (a36f952) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5008      +/-   ##
==========================================
- Coverage   88.00%   87.84%   -0.17%     
==========================================
  Files         158      158              
  Lines        9723     9723              
  Branches     1433     1433              
==========================================
- Hits         8557     8541      -16     
- Misses        911      928      +17     
+ Partials      255      254       -1     
Impacted Files Coverage Δ
scrapy/robotstxt.py 75.30% <0.00%> (-22.23%) ⬇️
scrapy/core/downloader/__init__.py 92.48% <0.00%> (+1.50%) ⬆️

@kmike
Copy link
Member

kmike commented Feb 24, 2021

Thanks @Gallaecio!

@kmike kmike merged commit bda5472 into scrapy:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSV item exporter does not flush on close
2 participants