Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: Cover scrapy-bench in the documentation #5016

Merged
merged 5 commits into from
Mar 11, 2021
Merged

DOCS: Cover scrapy-bench in the documentation #5016

merged 5 commits into from
Mar 11, 2021

Conversation

deepang17
Copy link
Contributor

@deepang17 deepang17 commented Feb 28, 2021

Resolves #4996.

@deepang17
Copy link
Contributor Author

@Gallaecio Please review the changes. Thank you

.vscode/settings.json Outdated Show resolved Hide resolved
docs/topics/benchmarking.rst Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #5016 (5d8ead8) into master (954c4b4) will decrease coverage by 1.64%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5016      +/-   ##
==========================================
- Coverage   88.01%   86.36%   -1.65%     
==========================================
  Files         158      158              
  Lines        9726     9726              
  Branches     1433     1433              
==========================================
- Hits         8560     8400     -160     
- Misses        911     1069     +158     
- Partials      255      257       +2     
Impacted Files Coverage Δ
scrapy/utils/asyncgen.py 20.00% <0.00%> (-80.00%) ⬇️
scrapy/shell.py 22.65% <0.00%> (-45.32%) ⬇️
scrapy/robotstxt.py 55.55% <0.00%> (-41.98%) ⬇️
scrapy/spiders/__init__.py 67.64% <0.00%> (-32.36%) ⬇️
scrapy/utils/test.py 43.75% <0.00%> (-17.19%) ⬇️
scrapy/utils/ssl.py 53.65% <0.00%> (-17.08%) ⬇️
scrapy/utils/spider.py 69.69% <0.00%> (-12.13%) ⬇️
scrapy/extensions/feedexport.py 91.00% <0.00%> (-4.32%) ⬇️
scrapy/core/scraper.py 87.11% <0.00%> (-2.46%) ⬇️
scrapy/extensions/memusage.py 47.82% <0.00%> (-2.18%) ⬇️
... and 1 more

@kmike kmike merged commit ab037ab into scrapy:master Mar 11, 2021
@deepang17 deepang17 deleted the scrapy-4996 branch March 12, 2021 03:18
@deepang17 deepang17 restored the scrapy-4996 branch April 28, 2021 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cover scrapy-bench in the documentation
3 participants