Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pip<20.3 to fix ReadTheDocs builds #5052

Merged
merged 1 commit into from Mar 19, 2021

Conversation

Gallaecio
Copy link
Member

@Gallaecio Gallaecio commented Mar 18, 2021

Tested in a custom ReadTheDocs project.

@Gallaecio Gallaecio closed this Mar 19, 2021
@Gallaecio Gallaecio reopened this Mar 19, 2021
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #5052 (8ff5dde) into master (42e4dbb) will increase coverage by 0.17%.
The diff coverage is 90.17%.

❗ Current head 8ff5dde differs from pull request most recent head 64749c6. Consider uploading reports for the commit 64749c6 to get more accurate results

@@            Coverage Diff             @@
##           master    #5052      +/-   ##
==========================================
+ Coverage   87.82%   88.00%   +0.17%     
==========================================
  Files         158      162       +4     
  Lines        9736    10284     +548     
  Branches     1435     1499      +64     
==========================================
+ Hits         8551     9050     +499     
- Misses        929      964      +35     
- Partials      256      270      +14     
Impacted Files Coverage Δ
scrapy/utils/log.py 89.24% <ø> (ø)
scrapy/core/http2/protocol.py 83.41% <83.41%> (ø)
scrapy/core/downloader/contextfactory.py 87.03% <84.61%> (-2.97%) ⬇️
scrapy/core/http2/stream.py 91.37% <91.37%> (ø)
scrapy/core/http2/agent.py 96.38% <96.38%> (ø)
scrapy/core/downloader/handlers/http11.py 93.85% <100.00%> (+1.16%) ⬆️
scrapy/core/downloader/handlers/http2.py 100.00% <100.00%> (ø)
... and 2 more

@Gallaecio Gallaecio merged commit 0dad0fc into scrapy:master Mar 19, 2021
@Gallaecio Gallaecio mentioned this pull request Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants