Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UsageError message #5063

merged 1 commit into from Apr 1, 2021


Copy link

This message was added 10 years ago (Scrapy 0.25.1), and I think that we can update it like this, as the feature of running more than one spider was deprecated a long time ago.

However, as this appears when we write more than one arg, it could be also a good idea to reformulate the whole message to give a hint like "did you forget to add -a / -s , etc". Or something similar.

Let me know what you think. :)

Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #5063 (739d0d5) into master (72e8cea) will increase coverage by 0.19%.
The diff coverage is 0.00%.

❗ Current head 739d0d5 differs from pull request most recent head 64d4ae1. Consider uploading reports for the commit 64d4ae1 to get more accurate results

@@            Coverage Diff             @@
##           master    #5063      +/-   ##
+ Coverage   87.63%   87.82%   +0.19%     
  Files         162      162              
  Lines       10301    10301              
  Branches     1501     1501              
+ Hits         9027     9047      +20     
+ Misses       1001      982      -19     
+ Partials      273      272       -1     
Impacted Files Coverage Δ
scrapy/commands/ 60.00% <0.00%> (ø)
scrapy/core/downloader/ 92.48% <0.00%> (+1.50%) ⬆️
scrapy/ 97.53% <0.00%> (+22.22%) ⬆️

Copy link
Member Author

I see that it could be a good idea to add a test too.

Copy link

I see that it could be a good idea to add a test too.

Do you want to give it a try as part of this pull request, or shall we merge and create a separate ticket for it?

@kmike kmike merged commit 127a858 into scrapy:master Apr 1, 2021
Copy link

kmike commented Apr 1, 2021

Let's handle tests separately, and get the improvement in. These tests would be unrelated to the change anyways - you can't write a test which checks that the readability improved :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants