Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] fix overriding url in FormRequest.from_response #507

Merged
merged 1 commit into from Dec 31, 2013

Conversation

@dangra
Copy link
Member

@dangra dangra commented Dec 30, 2013

originally reported in #scrapy IRC channel by pvt_petey.

@pablohoffman
Copy link
Member

@pablohoffman pablohoffman commented Dec 31, 2013

LGTM - doc update?

@dangra
Copy link
Member Author

@dangra dangra commented Dec 31, 2013

It is a bugfix, docs already says:

The other parameters of this class method are passed directly to the :class:FormRequest constructor.

pablohoffman added a commit that referenced this pull request Dec 31, 2013
[MRG] support overriding url in FormRequest.from_response
@pablohoffman pablohoffman merged commit e2f0918 into scrapy:master Dec 31, 2013
1 check passed
1 check passed
default The Travis CI build passed
Details
@dangra dangra deleted the dangra:fromresponse_override_url branch Dec 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.