[CRAWLERA-6612] Rebranding, updated GA code #5072
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5072 +/- ##
==========================================
- Coverage 88.19% 88.01% -0.18%
==========================================
Files 162 162
Lines 10300 10300
Branches 1500 1500
==========================================
- Hits 9084 9066 -18
- Misses 947 965 +18
Partials 269 269
|
| @@ -3,14 +3,9 @@ | |||
| {% block footer %} | |||
| {{ super() }} | |||
| <script type="text/javascript"> | |||
| !function(){var analytics=window.analytics=window.analytics||[];if(!analytics.initialize)if(analytics.invoked)window.console&&console.error&&console.error("Segment snippet included twice.");else{analytics.invoked=!0;analytics.methods=["trackSubmit","trackClick","trackLink","trackForm","pageview","identify","reset","group","track","ready","alias","page","once","off","on"];analytics.factory=function(t){return function(){var e=Array.prototype.slice.call(arguments);e.unshift(t);analytics.push(e);return analytics}};for(var t=0;t<analytics.methods.length;t++){var e=analytics.methods[t];analytics[e]=analytics.factory(e)}analytics.load=function(t){var e=document.createElement("script");e.type="text/javascript";e.async=!0;e.src=("https:"===document.location.protocol?"https://":"http://")+"cdn.segment.com/analytics.js/v1/"+t+"/analytics.min.js";var n=document.getElementsByTagName("script")[0];n.parentNode.insertBefore(e,n)};analytics.SNIPPET_VERSION="3.1.0"; | |||
There was a problem hiding this comment.
"legacy Segment tracking code. I don’t think we use Segment anymore."
There was a problem hiding this comment.
Correct. Only GA code needs to be updated
| @@ -3,14 +3,9 @@ | |||
| {% block footer %} | |||
| {{ super() }} | |||
| <script type="text/javascript"> | |||
| !function(){var analytics=window.analytics=window.analytics||[];if(!analytics.initialize)if(analytics.invoked)window.console&&console.error&&console.error("Segment snippet included twice.");else{analytics.invoked=!0;analytics.methods=["trackSubmit","trackClick","trackLink","trackForm","pageview","identify","reset","group","track","ready","alias","page","once","off","on"];analytics.factory=function(t){return function(){var e=Array.prototype.slice.call(arguments);e.unshift(t);analytics.push(e);return analytics}};for(var t=0;t<analytics.methods.length;t++){var e=analytics.methods[t];analytics[e]=analytics.factory(e)}analytics.load=function(t){var e=document.createElement("script");e.type="text/javascript";e.async=!0;e.src=("https:"===document.location.protocol?"https://":"http://")+"cdn.segment.com/analytics.js/v1/"+t+"/analytics.min.js";var n=document.getElementsByTagName("script")[0];n.parentNode.insertBefore(e,n)};analytics.SNIPPET_VERSION="3.1.0"; | |||
There was a problem hiding this comment.
Correct. Only GA code needs to be updated
|
@zseta @zloidemon The analytics code seems to fail now due to the removed line, because now the |
|
@Gallaecio Should we rollback the code (but keeping new domain)? I saw this PR: But this not belong to scrapy.org repo since the issue in here on docs (maybe move to scrapy repo then). |
|
Looks like that issue is both about scrapy.org and docs.scrapy.org (maybe they are even caused by different pieces of code?) |
|
Indeed. Let’s create a separate issue to deal with the docs.scrapy.org issue. |
No description provided.