Skip to content

Fix type for urlencode's doseq argument #5073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2021

Conversation

elacuesta
Copy link
Member

Continuation of #4950 (#4950 (review))

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #5073 (f147cea) into master (127a858) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head f147cea differs from pull request most recent head 9e7cbc0. Consider uploading reports for the commit 9e7cbc0 to get more accurate results

@@            Coverage Diff             @@
##           master    #5073      +/-   ##
==========================================
- Coverage   88.09%   88.07%   -0.02%     
==========================================
  Files         162      162              
  Lines       10347    10347              
  Branches     1504     1504              
==========================================
- Hits         9115     9113       -2     
- Misses        964      965       +1     
- Partials      268      269       +1     
Impacted Files Coverage Δ
scrapy/commands/bench.py 100.00% <100.00%> (ø)
scrapy/core/downloader/__init__.py 90.97% <0.00%> (-1.51%) ⬇️

@kmike kmike merged commit 8c5a3a5 into scrapy:master Apr 1, 2021
@kmike
Copy link
Member

kmike commented Apr 1, 2021

Thanks for the follow-up @elacuesta!

@elacuesta elacuesta deleted the fix-urlencode-doseq-arg branch April 1, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants