Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRAWLERA-6600] Renaming scrapy-crawlera to scrapy-zyte-proxy #5074

Merged
merged 3 commits into from
Jun 11, 2021

Conversation

zloidemon
Copy link
Contributor

Blocked by scrapy-crawlera PR-96.

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #5074 (a8bbd9d) into master (23cfdb0) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head a8bbd9d differs from pull request most recent head ba12f6d. Consider uploading reports for the commit ba12f6d to get more accurate results

@@            Coverage Diff             @@
##           master    #5074      +/-   ##
==========================================
- Coverage   88.16%   88.11%   -0.05%     
==========================================
  Files         162      162              
  Lines       10487    10487              
  Branches     1517     1517              
==========================================
- Hits         9246     9241       -5     
- Misses        966      970       +4     
- Partials      275      276       +1     
Impacted Files Coverage Δ
scrapy/core/downloader/handlers/http11.py 94.03% <ø> (ø)
scrapy/core/downloader/handlers/http2.py 100.00% <100.00%> (ø)
scrapy/core/downloader/handlers/__init__.py 83.63% <0.00%> (-9.10%) ⬇️

@zloidemon
Copy link
Contributor Author

@Gallaecio could you please look at this PR?

@zloidemon
Copy link
Contributor Author

Blocked by scrapy-crawlera PR-96.

Merged PR-97

@zloidemon
Copy link
Contributor Author

@Gallaecio Who can merge?

@Gallaecio
Copy link
Member

We usually wait for a second maintainer to approve changes before merging, but in this case I think we can just merge.

@Gallaecio Gallaecio merged commit e876d8e into scrapy:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants