Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataURI download handler in DOWNLOAD_HANDLERS_BASE documentation #5098

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

storymode7
Copy link
Contributor

DOWNLOAD_HANDLERS_BASE default setting mentioned in docs is missing DataURI download handler, that is present in scrapy/settings/default_settings.py

Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #5098 (14d28d5) into master (1850298) will decrease coverage by 0.17%.
The diff coverage is n/a.

❗ Current head 14d28d5 differs from pull request most recent head a4415e4. Consider uploading reports for the commit a4415e4 to get more accurate results

@@            Coverage Diff             @@
##           master    #5098      +/-   ##
==========================================
- Coverage   88.26%   88.09%   -0.18%     
==========================================
  Files         162      162              
  Lines       10345    10345              
  Branches     1504     1504              
==========================================
- Hits         9131     9113      -18     
- Misses        946      964      +18     
  Partials      268      268              
Impacted Files Coverage Δ
scrapy/robotstxt.py 75.30% <0.00%> (-22.23%) ⬇️

@wRAR wRAR merged commit 3801099 into scrapy:master Apr 13, 2021
@storymode7 storymode7 deleted the docs-update branch April 13, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants