Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some changes to subclass deprecation util on top of #501 #510

Merged
merged 8 commits into from Jan 1, 2014

Conversation

@dangra
Copy link
Member

@dangra dangra commented Dec 31, 2013

@kmike: Github doesn't allow me to submit a PR against your scrapy fork (#501), so I did against main repo, take a look at the changes and pull if you like them.

thanks.

kmike added 4 commits Dec 27, 2013
…for issubclass and isinstance checks to work if subclasses of non-deprecated class are checked against deprecated class.
@dangra

This comment has been minimized.

Copy link
Member

@dangra dangra commented on scrapy/utils/deprecate.py in 39458b7 Dec 30, 2013

IDEA: as classes are declared in order, with parents been defined before childs, it's possible to set a class attribute into the first class built from this metaclass.

and I think we can simplify finding the new class name by always pointing to the first second element of the MRO.

@kmike
Copy link
Member

@kmike kmike commented Jan 1, 2014

Hey @dangra, nice changes!

kmike added a commit that referenced this pull request Jan 1, 2014
Rename BaseSpider to Spider. Fixes #495, fixes #501.
@kmike kmike merged commit d7fbccd into scrapy:master Jan 1, 2014
1 check passed
1 check passed
default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.