Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dupefilter type hints #5108

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Dupefilter type hints #5108

merged 1 commit into from
Apr 20, 2021

Conversation

elacuesta
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #5108 (dac7354) into master (7e23677) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

❗ Current head dac7354 differs from pull request most recent head f6d983a. Consider uploading reports for the commit f6d983a to get more accurate results

@@            Coverage Diff             @@
##           master    #5108      +/-   ##
==========================================
- Coverage   88.19%   88.01%   -0.19%     
==========================================
  Files         162      162              
  Lines       10392    10401       +9     
  Branches     1510     1510              
==========================================
- Hits         9165     9154      -11     
- Misses        952      971      +19     
- Partials      275      276       +1     
Impacted Files Coverage Δ
scrapy/utils/request.py 100.00% <ø> (ø)
scrapy/core/engine.py 84.18% <100.00%> (+0.06%) ⬆️
scrapy/dupefilters.py 98.36% <100.00%> (+0.24%) ⬆️
scrapy/robotstxt.py 75.30% <0.00%> (-22.23%) ⬇️
scrapy/core/downloader/__init__.py 90.97% <0.00%> (-1.51%) ⬇️

@Gallaecio Gallaecio merged commit e779ed7 into scrapy:master Apr 20, 2021
@elacuesta elacuesta deleted the dupefilter-types branch April 20, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants