Add peek method to queues #5112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5112 +/- ##
==========================================
+ Coverage 88.20% 88.25% +0.05%
==========================================
Files 162 162
Lines 10401 10430 +29
Branches 1510 1514 +4
==========================================
+ Hits 9174 9205 +31
+ Misses 952 951 -1
+ Partials 275 274 -1
|
elacuesta
commented
Apr 25, 2021
| @@ -24,6 +24,7 @@ disable=abstract-method, | |||
| consider-using-in, | |||
| consider-using-set-comprehension, | |||
| consider-using-sys-exit, | |||
| consider-using-with, | |||
There was a problem hiding this comment.
Not really related, but the most recent pylint update (2.8.0) is making the build fail.
Gallaecio
reviewed
Apr 26, 2021
Gallaecio
approved these changes
Apr 26, 2021
Co-authored-by: Adrián Chaves <adrian@chaves.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
peekmethod after https://github.com/scrapy/queuelib/releases/tag/v1.6.1Some Scrapy tests inherit from the queuelib ones and are failing (https://github.com/scrapy/scrapy/runs/2411643205 for instance), this fixes it.
Test coverage is not yet complete, I'm working on it