Make Twisted[http2] installation optional #5113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This may be it, to be re-run once #5112 is merged. |
Codecov Report
@@ Coverage Diff @@
## master #5113 +/- ##
==========================================
+ Coverage 88.27% 88.32% +0.04%
==========================================
Files 162 162
Lines 10474 10474
Branches 1517 1517
==========================================
+ Hits 9246 9251 +5
+ Misses 953 949 -4
+ Partials 275 274 -1
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given issues like conda-forge/scrapy-feedstock#56 and emmett-framework/emmett#315, make h2 installation optional to allow installing Scrapy in environments where installing h2 < 4 is not possible.