Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate unused squeues #5117

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Conversation

elacuesta
Copy link
Member

These queues are not used anywhere else, they are middle steps in the construction of other queues. Moreover, I think their names are misleading: I would read "NonRequest" as "not being able to handle requests", which they are.

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #5117 (a5c19af) into master (6837919) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5117      +/-   ##
==========================================
- Coverage   88.25%   88.09%   -0.17%     
==========================================
  Files         162      162              
  Lines       10430    10437       +7     
  Branches     1514     1514              
==========================================
- Hits         9205     9194      -11     
- Misses        951      969      +18     
  Partials      274      274              
Impacted Files Coverage Δ
scrapy/squeues.py 100.00% <100.00%> (ø)
scrapy/robotstxt.py 75.30% <0.00%> (-22.23%) ⬇️

@elacuesta elacuesta merged commit 02ae1de into scrapy:master Apr 27, 2021
@elacuesta elacuesta deleted the deprecate-unused-squeues branch April 27, 2021 12:41
@elacuesta elacuesta added this to the 2.6 milestone Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants