Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require setuptools, scrapy/cmdline.py, /setup.py and tests/test_webclient.py import pkg_resources #5122

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

hrnciar
Copy link
Contributor

@hrnciar hrnciar commented Apr 28, 2021

No description provided.

Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. I believe we missed this because it’s very often installed by default.

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #5122 (44bfae8) into master (02ae1de) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 44bfae8 differs from pull request most recent head 4f50034. Consider uploading reports for the commit 4f50034 to get more accurate results

@@            Coverage Diff             @@
##           master    #5122      +/-   ##
==========================================
- Coverage   88.27%   88.25%   -0.02%     
==========================================
  Files         162      162              
  Lines       10474    10474              
  Branches     1517     1517              
==========================================
- Hits         9246     9244       -2     
- Misses        953      954       +1     
- Partials      275      276       +1     
Impacted Files Coverage Δ
scrapy/core/downloader/__init__.py 90.97% <0.00%> (-1.51%) ⬇️

@wRAR wRAR merged commit e27eff4 into scrapy:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants