changing dunder-str to dunder-repr #5150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5150 +/- ##
==========================================
+ Coverage 84.16% 88.90% +4.73%
==========================================
Files 162 162
Lines 10524 10964 +440
Branches 1522 1799 +277
==========================================
+ Hits 8858 9747 +889
+ Misses 1406 936 -470
- Partials 260 281 +21
|
Gallaecio
approved these changes
Jul 14, 2021
wRAR
reviewed
Jul 15, 2021
scrapy/core/http2/stream.py
Outdated
| @@ -151,11 +151,9 @@ def _cancel(_) -> None: | |||
|
|
|||
| self._deferred_response = Deferred(_cancel) | |||
|
|
|||
| def __str__(self) -> str: | |||
| def __repr__(self): | |||
There was a problem hiding this comment.
Should the typing be added here too?
scrapy/http/request/__init__.py
Outdated
| @@ -121,11 +121,9 @@ def _set_body(self, body: Optional[Union[str, bytes]]) -> None: | |||
| def encoding(self) -> str: | |||
| return self._encoding | |||
|
|
|||
| def __str__(self) -> str: | |||
| def __repr__(self): | |||
There was a problem hiding this comment.
Should the typing be added here too?
wRAR
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Changing all dunder-str to dunder-repr
Why:
Some __repr__ were being set as __repr__ = __str__, we actually dont need this because if the compiler does not find __str__, then it will get __repr__ as an alternative.
Proof:
https://onecompiler.com/python/3wxqqch57