Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing amount of warnings during test run #5162

Merged
merged 12 commits into from
May 28, 2021

Conversation

whalebot-helmsman
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #5162 (47e305e) into master (c5b1ee8) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

❗ Current head 47e305e differs from pull request most recent head f9ffaaf. Consider uploading reports for the commit f9ffaaf to get more accurate results

@@            Coverage Diff             @@
##           master    #5162      +/-   ##
==========================================
- Coverage   88.18%   88.16%   -0.02%     
==========================================
  Files         162      162              
  Lines       10485    10487       +2     
  Branches     1517     1517              
==========================================
  Hits         9246     9246              
- Misses        965      966       +1     
- Partials      274      275       +1     
Impacted Files Coverage Δ
scrapy/core/downloader/handlers/http11.py 94.03% <75.00%> (+0.03%) ⬆️
scrapy/core/downloader/__init__.py 90.97% <0.00%> (-1.51%) ⬇️

pytest.ini Show resolved Hide resolved
scrapy/core/engine.py Outdated Show resolved Hide resolved
@kmike
Copy link
Member

kmike commented May 28, 2021

Nice, thanks @whalebot-helmsman!

@kmike kmike merged commit 23cfdb0 into scrapy:master May 28, 2021
@whalebot-helmsman whalebot-helmsman deleted the warnings-removal branch May 28, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants