Feeds: Item Filters #5178
Merged
Feeds: Item Filters #5178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drs-11
commented
Jun 11, 2021
Codecov Report
@@ Coverage Diff @@
## master #5178 +/- ##
==========================================
- Coverage 88.19% 84.16% -4.03%
==========================================
Files 162 162
Lines 10497 10523 +26
Branches 1517 1522 +5
==========================================
- Hits 9258 8857 -401
- Misses 965 1406 +441
+ Partials 274 260 -14
|
Gallaecio
reviewed
Jun 11, 2021
Gallaecio
reviewed
Jun 13, 2021
Gallaecio
approved these changes
Jun 18, 2021
|
Sorry, I went ahead of myself. We still need documentation changes (see #4576). |
drs-11
commented
Jun 18, 2021
Gallaecio
reviewed
Jun 18, 2021
adityaa30
reviewed
Jun 21, 2021
Comment on lines
+934
to
+937
| items = [ | ||
| self.MyItem({'foo': 'bar1', 'egg': 'spam1'}), | ||
| self.MyItem2({'hello': 'world2', 'foo': 'bar2'}), | ||
| {'hello': 'world3', 'egg': 'spam3'}, |
There was a problem hiding this comment.
In case you plan to use these inputs for more tests, can we declare these as constants at the top?
There was a problem hiding this comment.
I'll keep this in mind next time I add tests.
Gallaecio
reviewed
Jun 21, 2021
Gallaecio
reviewed
Jun 23, 2021
Gallaecio
approved these changes
Jun 23, 2021
adityaa30
approved these changes
Jun 28, 2021
wRAR
approved these changes
Jul 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scrapy currently doesn't have any convenient APIs to customize conditions for item exports. An
ItemCheckerclass can be used by the user to define constraints for acceptable items for particular feeds.Resolves #5161, resolves #4576