Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the pylint test pass #5207

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Make the pylint test pass #5207

merged 2 commits into from
Jul 16, 2021

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Jul 16, 2021

This cherry-picks the pip fix from #5160 and makes the test pass with the current pylint by disabling the following recently added checks:

  • arguments-renamed
  • consider-using-dict-items
  • consider-using-from-import
  • unused-private-member

The pylint output without disabling these can be seen at https://github.com/wRAR/scrapy/runs/3084906465?check_suite_focus=true

Feel free to suggest fixing some of them instead of disabling them.

@wRAR wRAR added the CI label Jul 16, 2021
@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #5207 (02ad20d) into master (bcce066) will increase coverage by 3.84%.
The diff coverage is n/a.

❗ Current head 02ad20d differs from pull request most recent head 2948d12. Consider uploading reports for the commit 2948d12 to get more accurate results

@@            Coverage Diff             @@
##           master    #5207      +/-   ##
==========================================
+ Coverage   84.15%   88.00%   +3.84%     
==========================================
  Files         162      162              
  Lines       10526    10526              
  Branches     1522     1522              
==========================================
+ Hits         8858     9263     +405     
+ Misses       1407      985     -422     
- Partials      261      278      +17     
Impacted Files Coverage Δ
scrapy/pipelines/media.py 97.16% <0.00%> (+5.67%) ⬆️
scrapy/core/downloader/contextfactory.py 87.03% <0.00%> (+11.11%) ⬆️
scrapy/robotstxt.py 97.53% <0.00%> (+22.22%) ⬆️
scrapy/core/http2/protocol.py 82.91% <0.00%> (+48.74%) ⬆️
scrapy/core/downloader/handlers/http2.py 100.00% <0.00%> (+56.57%) ⬆️
scrapy/core/http2/agent.py 96.38% <0.00%> (+60.24%) ⬆️
scrapy/pipelines/images.py 90.35% <0.00%> (+62.28%) ⬆️
scrapy/core/http2/stream.py 91.37% <0.00%> (+64.36%) ⬆️

@Gallaecio Gallaecio merged commit 89b654b into scrapy:master Jul 16, 2021
@wRAR wRAR deleted the fix-pylint branch July 16, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants