-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup leftover boto2 code in S3DownloaderHandler #5209
Cleanup leftover boto2 code in S3DownloaderHandler #5209
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5209 +/- ##
==========================================
- Coverage 88.38% 84.14% -4.24%
==========================================
Files 162 162
Lines 10526 10523 -3
Branches 1522 1522
==========================================
- Hits 9303 8855 -448
- Misses 947 1406 +459
+ Partials 276 262 -14
|
Please fix the flake8 failure. |
2ee3245
to
b52bfdd
Compare
Fixed the linting error. There's another BTW, I have problem running |
`S3DownloaderHandler.conn` is leftover attr from 5e99758.
b52bfdd
to
7b02d1e
Compare
Thanks! |
Remove leftover attribute
S3DownloaderHandler.conn
. Seems we forgot to remove it in 5e99758.