Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup leftover boto2 code in S3DownloaderHandler #5209

Merged

Conversation

laggardkernel
Copy link
Contributor

Remove leftover attribute S3DownloaderHandler.conn. Seems we forgot to remove it in 5e99758.

@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #5209 (1efed43) into master (b22a004) will decrease coverage by 4.23%.
The diff coverage is n/a.

❗ Current head 1efed43 differs from pull request most recent head 7b02d1e. Consider uploading reports for the commit 7b02d1e to get more accurate results

@@            Coverage Diff             @@
##           master    #5209      +/-   ##
==========================================
- Coverage   88.38%   84.14%   -4.24%     
==========================================
  Files         162      162              
  Lines       10526    10523       -3     
  Branches     1522     1522              
==========================================
- Hits         9303     8855     -448     
- Misses        947     1406     +459     
+ Partials      276      262      -14     
Impacted Files Coverage Δ
scrapy/core/downloader/handlers/s3.py 93.33% <ø> (+3.75%) ⬆️
scrapy/core/http2/stream.py 27.01% <0.00%> (-64.37%) ⬇️
scrapy/pipelines/images.py 28.07% <0.00%> (-62.29%) ⬇️
scrapy/core/http2/agent.py 36.14% <0.00%> (-60.25%) ⬇️
scrapy/core/downloader/handlers/http2.py 43.42% <0.00%> (-56.58%) ⬇️
scrapy/core/http2/protocol.py 34.17% <0.00%> (-49.25%) ⬇️
scrapy/robotstxt.py 75.30% <0.00%> (-22.23%) ⬇️
scrapy/utils/ssl.py 53.65% <0.00%> (-17.08%) ⬇️
scrapy/utils/asyncgen.py 83.33% <0.00%> (-16.67%) ⬇️
scrapy/core/downloader/contextfactory.py 75.92% <0.00%> (-11.12%) ⬇️
... and 7 more

@wRAR
Copy link
Member

wRAR commented Jul 20, 2021

Please fix the flake8 failure.

@wRAR wRAR closed this Jul 20, 2021
@wRAR wRAR reopened this Jul 20, 2021
@laggardkernel
Copy link
Contributor Author

Fixed the linting error. There's another requests connection error raised during generating document. Seems unrelated with my code.

BTW, I have problem running tox on my local machine. pip stucks at dependencies resolving.

@wRAR wRAR added the cleanup label Jul 22, 2021
`S3DownloaderHandler.conn` is leftover attr from 5e99758.
@Gallaecio Gallaecio merged commit abe0b37 into scrapy:master Jul 27, 2021
@Gallaecio
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants