Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add imports for Spider dependencies #521

Closed
wants to merge 1 commit into from
Closed

add imports for Spider dependencies #521

wants to merge 1 commit into from

Conversation

@hobson
Copy link
Contributor

@hobson hobson commented Jan 9, 2014

imports in one "at a glance" example that was missing them

@@ -135,6 +135,9 @@ For more information about XPath see the `XPath reference`_.

Finally, here's the spider code::

from scrapy.contrib.spiders import CrawlSpider, Rule, SgmlLinkExtractor
from scrapy.contrib.linkextractors.sgml import SgmlLinkExtractor, Selector

This comment has been minimized.

@pablohoffman

pablohoffman Jan 10, 2014
Member

Selector should be imported from scrapy.selector

This comment has been minimized.

@hobson

hobson Jan 10, 2014
Author Contributor

Yea, noticed that once I got to know scrapy a bit better.

@@ -135,6 +135,9 @@ For more information about XPath see the `XPath reference`_.

Finally, here's the spider code::

from scrapy.contrib.spiders import CrawlSpider, Rule, SgmlLinkExtractor

This comment has been minimized.

@pablohoffman

pablohoffman Jan 10, 2014
Member

SgmlLinkExtractor is duplicated in the line below (where it should be imported)

This comment has been minimized.

@hobson

hobson Jan 10, 2014
Author Contributor

good catch

@hobson hobson closed this Jan 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants