Reference MailSender in StatsMailer #5217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a reference to MailSender in the StatsMailer extension description and included a link to the document detailing how to instantiate MailSender and using Scrapy settings objects.
Codecov Report
@@ Coverage Diff @@
## master #5217 +/- ##
=======================================
Coverage 88.42% 88.42%
=======================================
Files 162 162
Lines 10527 10527
Branches 1522 1522
=======================================
Hits 9308 9308
Misses 944 944
Partials 275 275 |
|
The docs build failed with "docs/topics/extensions.rst:328:duplicate object description of scrapy.mail, other instance in topics/email, use :noindex: for one of them", can you please look into that? |
Gallaecio
reviewed
Jul 31, 2021
Co-authored-by: Adrián Chaves <adrian@chaves.io>
Gallaecio
approved these changes
Aug 2, 2021
wRAR
approved these changes
Aug 2, 2021
|
Thanks! |
|
No problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5199
Added a reference to MailSender in the StatsMailer extension description and included a link to the document detailing how to instantiate MailSender and using Scrapy settings objects.
If there is any issue with my pull request please don't hesitate to tell me and I'll be happy to address/fix them.