Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable builtin middlewares in spider middleware tests. #5229

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

wRAR
Copy link
Member

@wRAR wRAR commented Aug 16, 2021

When adding new tests for async middlewares I've found that the default ones are silently enabled in the existing tests, which interferes with things I want to test, I think if we need to test how it works with the default ones we can do that explicitly.

@wRAR wRAR added the CI label Aug 16, 2021
@codecov
Copy link

codecov bot commented Aug 16, 2021

Codecov Report

Merging #5229 (1a17ef1) into master (47a281d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5229   +/-   ##
=======================================
  Coverage   88.45%   88.45%           
=======================================
  Files         162      162           
  Lines       10529    10529           
  Branches     1522     1522           
=======================================
  Hits         9313     9313           
  Misses        942      942           
  Partials      274      274           

@Gallaecio Gallaecio merged commit 2814e0e into scrapy:master Aug 16, 2021
@wRAR wRAR deleted the tests-default-mws branch May 8, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants