-
Notifications
You must be signed in to change notification settings - Fork 10.9k
updated documentation for python version for reppy #5231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Adrián Chaves <adrian@chaves.io>
seems good to me now @Gallaecio .... |
Codecov Report
@@ Coverage Diff @@
## master #5231 +/- ##
==========================================
- Coverage 88.45% 87.94% -0.51%
==========================================
Files 162 162
Lines 10529 10417 -112
Branches 1522 1520 -2
==========================================
- Hits 9313 9161 -152
- Misses 942 976 +34
- Partials 274 280 +6
|
Should we link to the upstream issue and/or say that this may be false if the library is already fixed? |
Can you please explain @wRAR ? |
I mean currently reppy doesn't work on 3.9 but it can be fixed in the future which will make our doc incorrect. |
yes right... So what do you suggest @wRAR ? |
@Gallaecio and @wRAR should we do this in our docs ? |
I agree with @wRAR. Maybe something something like this? .. warning:: `Upstream issue #122
<https://github.com/seomoz/reppy/issues/122>`_ prevents reppy usage in
Python 3.9+. |
Updated @Gallaecio .Thanks ...! |
This PR fixes issue #5226