Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation code example corrections per pablohoffman #524

Merged
merged 3 commits into from Jan 16, 2014

Conversation

@hobson
Copy link
Contributor

@hobson hobson commented Jan 10, 2014

Help new users find the right module to import for the code examples in documentation. There are multiple import paths, so it also helps to point new users tot he canonical path (as @pablohoffman did for me).

@@ -135,6 +135,10 @@ For more information about XPath see the `XPath reference`_.

Finally, here's the spider code::

from scrapy.contrib.spiders import CrawlSpider, Rule
from scrapy.contrib.linkextractors.sgml import SgmlLinkExtractor
from scrapy.selectors import Selector

This comment has been minimized.

@pablohoffman

pablohoffman Jan 15, 2014
Member

it's scrapy.selector not scrapy.selectors

This comment has been minimized.

@hobson

hobson Jan 15, 2014
Author Contributor

right you are... again

This comment has been minimized.

@pablohoffman

pablohoffman Jan 15, 2014
Member

that's what pull requests & CRs are for :)

@kmike
Copy link
Member

@kmike kmike commented Jan 15, 2014

There are similar issues in other doc examples: #493 - if you're into it, more pull requests are very welcome!

As for this PR, there is

For brevity's sake, we intentionally left out the import statements.

statement right after the code example - it is no longer correct. Could you please remove it?

@hobson
Copy link
Contributor Author

@hobson hobson commented Jan 16, 2014

wilco

On Wed, Jan 15, 2014 at 4:16 AM, Mikhail Korobov
notifications@github.comwrote:

There are similar issues in other doc examples: #493https://github.com/scrapy/scrapy/issues/493\- if you're into it, more pull requests are very welcome!

As for this PR, there is

For brevity's sake, we intentionally left out the import statements.

statement right after the code example - it is no longer correct. Could
you please remove it?


Reply to this email directly or view it on GitHubhttps://github.com//pull/524#issuecomment-32356574
.

Torrent item -> TorrentItem class
pablohoffman added a commit that referenced this pull request Jan 16, 2014
documentation code example corrections per pablohoffman
@pablohoffman pablohoffman merged commit ed6fd49 into scrapy:master Jan 16, 2014
1 check failed
1 check failed
default The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants