Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update Python 3.10 environment #5265

Merged
merged 9 commits into from
Oct 18, 2021

Conversation

elacuesta
Copy link
Member

@elacuesta elacuesta added the CI label Oct 6, 2021
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #5265 (c54cf4f) into master (afa5881) will not change coverage.
The diff coverage is n/a.

❗ Current head c54cf4f differs from pull request most recent head faa8527. Consider uploading reports for the commit faa8527 to get more accurate results

@@           Coverage Diff           @@
##           master    #5265   +/-   ##
=======================================
  Coverage   88.52%   88.52%           
=======================================
  Files         163      163           
  Lines       10610    10610           
  Branches     1557     1557           
=======================================
  Hits         9393     9393           
  Misses        942      942           
  Partials      275      275           

@Gallaecio Gallaecio self-requested a review October 6, 2021 17:36
@Gallaecio
Copy link
Member

Nice. But I would say you are not done yet. 🙂

@Gallaecio
Copy link
Member

I suggest also updating .github/workflows/checks.yml and .github/workflows/publish.yml to use 3.10.

The documentation job may be able to use 3.10 now as well.

@wRAR
Copy link
Member

wRAR commented Oct 13, 2021

Waiting for the changes requested above :)

@Gallaecio
Copy link
Member

When upgrading the Python version of the docs build, please make this change from parsel as well.

@Gallaecio Gallaecio self-requested a review October 13, 2021 11:47
@Gallaecio Gallaecio added this to the 2.6 milestone Oct 16, 2021
@@ -20,10 +20,10 @@ jobs:
env:
TOXENV: pylint
TOX_PIP_VERSION: 20.3.3
- python-version: 3.9
- python-version: 3.6
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, to prevent errors from things like Typing.Dict/List being deprecated in favor of the built-ins.

@Gallaecio
Copy link
Member

From reading the mypy failure and related information, it looks like mypy includes type hint annotations for the built-in dataclasses, but because Python 3.6 still requires a separate package for dataclass support, that does not work. I guess we should install types-dataclasses in the mypy Tox when running Python 3.6.

@Gallaecio Gallaecio self-requested a review October 18, 2021 17:31
@Gallaecio Gallaecio merged commit cfff79c into scrapy:master Oct 18, 2021
@elacuesta elacuesta deleted the ci-update-py310-env branch October 19, 2021 18:10
darakian pushed a commit to darakian/scrapy that referenced this pull request Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants