-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Update Python 3.10 environment #5265
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5265 +/- ##
=======================================
Coverage 88.52% 88.52%
=======================================
Files 163 163
Lines 10610 10610
Branches 1557 1557
=======================================
Hits 9393 9393
Misses 942 942
Partials 275 275 |
Nice. But I would say you are not done yet. 🙂 |
I suggest also updating The documentation job may be able to use 3.10 now as well. |
Waiting for the changes requested above :) |
When upgrading the Python version of the docs build, please make this change from parsel as well. |
@@ -20,10 +20,10 @@ jobs: | |||
env: | |||
TOXENV: pylint | |||
TOX_PIP_VERSION: 20.3.3 | |||
- python-version: 3.9 | |||
- python-version: 3.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, to prevent errors from things like Typing.Dict/List
being deprecated in favor of the built-ins.
From reading the mypy failure and related information, it looks like |
Should be possible after the recent GA release of Python 3.10, and its addition as a supported version for GitHub actions.