Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed documentation example #5266

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Fixed documentation example #5266

merged 1 commit into from
Oct 12, 2021

Conversation

MarvinPetzoldt
Copy link
Contributor

I think here the name parameter should be compared with the 'price'.

Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you!

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #5266 (2e3b0a3) into master (6c858ce) will not change coverage.
The diff coverage is n/a.

❗ Current head 2e3b0a3 differs from pull request most recent head b1cb007. Consider uploading reports for the commit b1cb007 to get more accurate results

@@           Coverage Diff           @@
##           master    #5266   +/-   ##
=======================================
  Coverage   88.52%   88.52%           
=======================================
  Files         163      163           
  Lines       10606    10606           
  Branches     1557     1557           
=======================================
  Hits         9389     9389           
  Misses        942      942           
  Partials      275      275           

@wRAR wRAR merged commit 8a743ae into scrapy:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants