Fix bug #5145 - Removing Selector for Response's that are not Http or Xml #5269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gallaecio
reviewed
Oct 10, 2021
Gallaecio
reviewed
Oct 10, 2021
|
It would be great to also get a test to prove the change works. |
Fix condition for failing tests set Selector to None on AttributeError Add test and remove unused imports Fix imports
Codecov Report
@@ Coverage Diff @@
## master #5269 +/- ##
=======================================
Coverage 88.52% 88.52%
=======================================
Files 163 163
Lines 10605 10608 +3
Branches 1557 1557
=======================================
+ Hits 9388 9391 +3
Misses 942 942
Partials 275 275
|
wRAR
approved these changes
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5145
Please provide feedback