Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unnecessary line from docs to prevent test failure to fix #5273 #5274

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

jmherbst
Copy link
Contributor

Fixes #5273

@jmherbst jmherbst changed the title Removing unnecessary line from docs to prevent test failure to fix https://github.com/scrapy/scrapy/issues/5273 Removing unnecessary line from docs to prevent test failure to fix #5273 Oct 12, 2021
@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #5274 (bf1c84b) into master (d90b2a2) will decrease coverage by 0.30%.
The diff coverage is n/a.

❗ Current head bf1c84b differs from pull request most recent head da0d7d8. Consider uploading reports for the commit da0d7d8 to get more accurate results

@@            Coverage Diff             @@
##           master    #5274      +/-   ##
==========================================
- Coverage   88.52%   88.22%   -0.31%     
==========================================
  Files         163      163              
  Lines       10605    10605              
  Branches     1557     1557              
==========================================
- Hits         9388     9356      -32     
- Misses        942      972      +30     
- Partials      275      277       +2     
Impacted Files Coverage Δ
scrapy/utils/asyncgen.py 33.33% <0.00%> (-66.67%) ⬇️
scrapy/robotstxt.py 75.30% <0.00%> (-22.23%) ⬇️
scrapy/utils/spider.py 69.69% <0.00%> (-12.13%) ⬇️
scrapy/utils/test.py 54.68% <0.00%> (-6.25%) ⬇️
scrapy/core/downloader/__init__.py 90.97% <0.00%> (-1.51%) ⬇️

@jmherbst
Copy link
Contributor Author

Thanks @wRAR ! Do we need someone else to handle the merge?

@Gallaecio
Copy link
Member

We go for 2-maintainer approvals before merging, which is done now. Thanks!

@Gallaecio Gallaecio merged commit d08199f into scrapy:master Oct 12, 2021
@jmherbst
Copy link
Contributor Author

Gotcha - Thank you both @wRAR + @Gallaecio 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doctest failure
3 participants