Set WindowsSelectorEventLoopPolicy on Windows. #5315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5315 +/- ##
==========================================
- Coverage 88.59% 88.56% -0.04%
==========================================
Files 163 163
Lines 10619 10624 +5
Branches 1807 1809 +2
==========================================
+ Hits 9408 9409 +1
- Misses 936 939 +3
- Partials 275 276 +1
|
|
Tests that hang on old Twisted because of https://twistedmatrix.com/trac/ticket/9390 also hang on Windows with these changes, I need to investigate the reason. |
wRAR
changed the title
|
Looks like there are several tests getting 100% reproducible unclean reactor problems only on windows-3.10-asyncio. |
wRAR
commented
Nov 23, 2021
|
I've filed https://twistedmatrix.com/trac/ticket/10279 and skipped those tests. |
Gallaecio
reviewed
Dec 31, 2021
Gallaecio
approved these changes
Dec 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4976
Needs fixing tests that expect a default loop to be used, and adding docs, including manual setting for CrawlerProcess/Runner in https://docs.scrapy.org/en/latest/topics/asyncio.html#installing-the-asyncio-reactor