-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve open_in_browser base tag injection (#5319) #5320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test for the fix and the other 2 scenarios I mention under my suggestion?
Codecov Report
@@ Coverage Diff @@
## master #5320 +/- ##
=======================================
Coverage 88.59% 88.59%
=======================================
Files 163 163
Lines 10616 10618 +2
Branches 1558 1558
=======================================
+ Hits 9405 9407 +2
Misses 936 936
Partials 275 275
|
@Gallaecio I've added your suggestions (fix and format) to the original commit, and a additional commit for test coverage. Note: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
Fixing flake8 failed check with python 3.10, related to the raw bytes regex. |
Fixes #5319
What changed
Use of
re.sub
instead ofreplace
to inject<base>
tag.