Skip to content

augmented assignment statements #5314 update #5322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

alexpdev
Copy link
Contributor

@alexpdev alexpdev commented Nov 16, 2021

Changed the 3 instances mentioned in Issue #5314

Fixes #5314, closes #5321.

@alexpdev
Copy link
Contributor Author

Since the changes in this PR didn't alter any functionality I didn't add any tests.

I know a pull request has already been submitted on this issue, but after reviewing the diff for that PR I decided to start over.

Let me know if I got anything wrong.

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #5322 (0287e18) into master (28eba61) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5322   +/-   ##
=======================================
  Coverage   88.59%   88.59%           
=======================================
  Files         163      163           
  Lines       10616    10616           
  Branches     1558     1558           
=======================================
  Hits         9405     9405           
  Misses        936      936           
  Partials      275      275           
Impacted Files Coverage Δ
scrapy/core/downloader/handlers/http11.py 94.11% <100.00%> (ø)
scrapy/core/http2/stream.py 91.37% <100.00%> (ø)

@Gallaecio Gallaecio merged commit c316ca4 into scrapy:master Nov 16, 2021
@elfring
Copy link

elfring commented Nov 16, 2021

Thanks for your small source code improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase the usage of augmented assignment statements
4 participants